Skip to content

Add top level attributes and commands to simplify API#82

Open
GDYendell wants to merge 3 commits intomainfrom
top-level-attributes
Open

Add top level attributes and commands to simplify API#82
GDYendell wants to merge 3 commits intomainfrom
top-level-attributes

Conversation

@GDYendell
Copy link
Contributor

@GDYendell GDYendell commented Dec 5, 2025

@GDYendell GDYendell requested a review from shihab-dls December 5, 2025 18:45
@GDYendell GDYendell linked an issue Jan 8, 2026 that may be closed by this pull request
@GDYendell GDYendell force-pushed the top-level-attributes branch 3 times, most recently from 68b31e4 to 1979b0c Compare January 14, 2026 09:30
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 87.30159% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.41%. Comparing base (a0e0654) to head (0b93fcf).

Files with missing lines Patch % Lines
...c/fastcs_eiger/controllers/odin/odin_controller.py 70.58% 5 Missing ⚠️
src/fastcs_eiger/__main__.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   85.27%   85.41%   +0.13%     
==========================================
  Files          13       14       +1     
  Lines         421      473      +52     
==========================================
+ Hits          359      404      +45     
- Misses         62       69       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@shihab-dls shihab-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a couple of comments that are just enquiries; Will request changes just so that you can rerequest a review when codecov is satisfied.

@GDYendell GDYendell force-pushed the top-level-attributes branch from dde6756 to 75a64f3 Compare March 5, 2026 13:35
Copy link
Contributor

@shihab-dls shihab-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, had a look at the new tests and timeout attributes since last time, and LGTM! Approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add attribute fan outs to reduce puts required for an acquisition

2 participants